zhangbutao commented on code in PR #5028: URL: https://github.com/apache/hive/pull/5028#discussion_r1470579963
########## parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g: ########## @@ -99,6 +100,19 @@ alterTblPartitionStatementSuffix[boolean partition] | alterStatementSuffixAddCol | alterStatementSuffixUpdateColumns ; + +optimizeTableStatementSuffix Review Comment: We already have `alter table execute` syntax for partial iceberg maintance operations: https://github.com/apache/hive/blob/94f318959ca6ec5f815e6326241bd2269ce91b80/parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g#L473 How do we distinguish between the two syntax? Is the `optimize` only used for iceberg compaction? I'm not opposed to adding new syntax, but i think we need to clarify the specific use cases to avoid users confusion. cc @ayushtkn @deniskuzZ any thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
