simhadri-g commented on code in PR #5014: URL: https://github.com/apache/hive/pull/5014#discussion_r1475270157
########## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUtcTimestamp.java: ########## @@ -44,7 +46,11 @@ public String getName() { } @Override - protected boolean invert() { - return true; + protected TimeZone getToTimeZone(TimeZone timezone) { + return tzUTC; Review Comment: do we need to pass timezone in the arguments? We are returning UTC here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org