deniskuzZ commented on code in PR #5060:
URL: https://github.com/apache/hive/pull/5060#discussion_r1483283887
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -489,18 +488,26 @@ protected String defaultWarehouseLocation(TableIdentifier
tableIdentifier) {
}
private String databaseLocation(String databaseName) {
- String warehouseLocation =
conf.get(HiveConf.ConfVars.METASTORE_WAREHOUSE.varname);
- Preconditions.checkNotNull(
- warehouseLocation, "Warehouse location is not set:
hive.metastore.warehouse.dir=null");
+ String warehouseLocation = conf.get("metastore.warehouse.dir");
Review Comment:
what is this? maybe
````
conf.get(MetastoreConf.ConfVars.WAREHOUSE.getVarname())
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
