deniskuzZ commented on code in PR #4943:
URL: https://github.com/apache/hive/pull/4943#discussion_r1484133435
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/AlterMaterializedViewRebuildAnalyzer.java:
##########
@@ -322,8 +373,7 @@ private RelNode applyRecordIncrementalRebuildPlan(
}
return applyAggregateInsertDeleteIncremental(basePlan,
mdProvider, executorProvider);
} else {
- return applyJoinInsertDeleteIncremental(
- basePlan, mdProvider, executorProvider, optCluster,
calcitePreMVRewritingPlan);
+ return calcitePreMVRewritingPlan;
Review Comment:
can we remove nesting and combine
````
if (acidView && visitor.isContainsAggregate()) {
....
}
return calcitePreMVRewritingPlan;
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
