abstractdog commented on code in PR #5054:
URL: https://github.com/apache/hive/pull/5054#discussion_r1484727510
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -5508,6 +5508,17 @@ public static enum ConfVars {
LLAP_TASK_TIME_SUMMARY(
"hive.llap.task.time.print.summary", false,
"Display queue and runtime of tasks by host for every query executed
by the shell."),
+
+ LLAP_LOCAL_DIR_CLEANER_CLEANUP_INTERVAL(
Review Comment:
checked
[ClearDanglingScratchDir](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/session/ClearDanglingScratchDir.java),
it seems to be specific to scratch dir cleanup and it's too smart for this
scenario, I feel it would be more complicated to make it general and reuse than
having a simple utility for the cases: ClearDanglingScratchDir checks lock
files, works on hdfs, has a command line utility, etc., whereas LocalDirCleaner
is just about to remove old files from a local folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
