armitage420 commented on PR #5071: URL: https://github.com/apache/hive/pull/5071#issuecomment-1937807413
> <img alt="image" width="463" src="https://private-user-images.githubusercontent.com/25608848/302986625-b27ce34e-119c-48a5-8a0e-4e1a3d7abcb4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDc2NzA2NDEsIm5iZiI6MTcwNzY3MDM0MSwicGF0aCI6Ii8yNTYwODg0OC8zMDI5ODY2MjUtYjI3Y2UzNGUtMTE5Yy00OGE1LThhMGUtNGUxYTNkN2FiY2I0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjExVDE2NTIyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJiZmU5OGQ4NzViYWY2YTU1NTVhNTMwNzM3ZTc3YTAzNjRmY2JiMDZjNzM3Njc3ZDQ2ZDVmMGFmOTc2NDUzYWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.W6i7fzMiiuPZGkjn8HweiDAedgYtxJihWF749bXNtJo";> > the title says "Upgrade Bouncy castle", how is this a "No"?, there are some steps mentioned in case of dependency upgade: https://github.com/apache/hive/blob/master/.github/pull_request_template.md?plain=1#L40-L44 Hello, I have made the required changes, and added the dependency tree for the reference too. Thank for reviewing my PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/25608848/302986625-b27ce34e-119c-48a5-8a0e-4e1a3d7abcb4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDc2NzA2NDEsIm5iZiI6MTcwNzY3MDM0MSwicGF0aCI6Ii8yNTYwODg0OC8zMDI5ODY2MjUtYjI3Y2UzNGUtMTE5Yy00OGE1LThhMGUtNGUxYTNkN2FiY2I0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjExVDE2NTIyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJiZmU5OGQ4NzViYWY2YTU1NTVhNTMwNzM3ZTc3YTAzNjRmY2JiMDZjNzM3Njc3ZDQ2ZDVmMGFmOTc2NDUzYWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.W6i7fzMiiuPZGkjn8HweiDAedgYtxJihWF749bXNtJo"](https://private-user-images.githubusercontent.com/25608848/302986625-b27ce34e-119c-48a5-8a0e-4e1a3d7abcb4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDc2NzA2NDEsIm5iZiI6MTcwNzY3MDM0MSwicGF0aCI6Ii8yNTYwODg0OC8zMDI5ODY2MjUtYjI3Y2UzNGUtMTE5Yy00OGE1LThhMGUtNGUxYTNkN2FiY2I0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjExVDE2NTIyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJiZmU5OGQ4NzViYWY2YTU1NTVhNTMwNzM3ZTc3YTAzNjRmY2JiMDZjNzM3Njc3ZDQ2ZDVmMGFmOTc2NDUzYWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.W6i7fzMiiuPZGkjn8HweiDAedgYtxJihWF749bXNtJo"){kind=link}