abstractdog commented on code in PR #4913: URL: https://github.com/apache/hive/pull/4913#discussion_r1485961528
########## itests/util/src/main/java/org/apache/hadoop/hive/ql/QOutProcessor.java: ########## @@ -310,6 +290,17 @@ LineProcessingResult processLine(String line) { return result; } + private void maskPattern(LineProcessingResult result, Mask mask, PatternReplacementPair patternReplacementPair) { + Matcher matcher; Review Comment: this declaration of matcher variable can go together with the definition, we have no reason to have them separated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org