kasakrisz commented on code in PR #4943: URL: https://github.com/apache/hive/pull/4943#discussion_r1486255491
########## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/MaterializedViewRewritingRelVisitor.java: ########## @@ -50,7 +49,7 @@ public class MaterializedViewRewritingRelVisitor extends RelVisitor { private boolean containsAggregate; - private boolean fullAcidView; + private final boolean fullAcidView; Review Comment: This class is not stateless. Fields ``` containsAggregate rewritingAllowed countIndex ``` are set during plan traversal but `fullAcidView` should not be changed since it's value depends on the MV metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org