dengzhhu653 commented on code in PR #5038:
URL: https://github.com/apache/hive/pull/5038#discussion_r1493772560
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -5094,26 +5094,22 @@ public static String verifyStatsChangeCtx(String
fullTableName, Map<String, Stri
if (validWriteIds != null && writeId > 0) {
return null; // We have txn context.
}
- String oldVal = oldP == null ? null :
oldP.get(StatsSetupConst.COLUMN_STATS_ACCURATE);
- String newVal = newP == null ? null :
newP.get(StatsSetupConst.COLUMN_STATS_ACCURATE);
- // We don't need txn context is that stats state is not being changed.
- if (StringUtils.isEmpty(oldVal) && StringUtils.isEmpty(newVal)) {
+
+ if (!StatsSetupConst.areBasicStatsUptoDate(newP)) {
+ // The validWriteIds can be absent, for example, in case of Impala alter.
Review Comment:
@deniskuzZ, sorry for the late reply!
The `validWriteIds` from impala engine is null, when the impala alters the
acid table(like the Test2 in the description), it would be failed as the
message shows:
>
ERROR : Failed
org.apache.hadoop.hive.ql.metadata.HiveException: Unable to alter table.
Cannot change stats state for a transactional table default.parqtest without
providing the transactional write state for verification (new write ID 6, valid
write IDs null; current state null; new state {}
If `StatsSetupConst.areBasicStatsUptoDate(newP)` is false for the new target
table, then the alter operation should go as it has marked the stats as stale
in the target table, it won't pollute the stats, nor cause trouble for Hive
query optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
