okumin commented on code in PR #5090:
URL: https://github.com/apache/hive/pull/5090#discussion_r1495362075
##########
ql/src/java/org/apache/hadoop/hive/ql/session/ClearDanglingScratchDir.java:
##########
@@ -252,17 +252,12 @@ static Options createOptions() {
*/
private void removeLocalTmpFiles(String sessionName, String localTmpdir) {
File[] files = new File(localTmpdir).listFiles(fn ->
fn.getName().startsWith(sessionName));
- boolean success;
if (files != null) {
Review Comment:
Sorry for the lack of words. I expected the following return would let us
know we do nothing on `else` a bit earlier.
```
if (files == null) {
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
