abstractdog commented on code in PR #5085:
URL: https://github.com/apache/hive/pull/5085#discussion_r1499522716
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestTxnDbUtil.java:
##########
@@ -338,10 +338,24 @@ public static int countQueryAgent(Configuration conf,
String countQuery) throws
closeResources(conn, stmt, rs);
}
}
+
public static String queryToString(Configuration conf, String query) throws
Exception {
return queryToString(conf, query, true);
}
- public static String queryToString(Configuration conf, String query, boolean
includeHeader)
+
+ public static String queryToString(Configuration conf, String query, boolean
includeHeader) throws Exception {
+ return queryToString(conf, query, includeHeader, " ");
+ }
+
+ public static String queryToCsv(Configuration conf, String query) throws
Exception {
Review Comment:
okay, it's for debugging purpose, it's fine to have it this way
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestTxnDbUtil.java:
##########
@@ -338,10 +338,24 @@ public static int countQueryAgent(Configuration conf,
String countQuery) throws
closeResources(conn, stmt, rs);
}
}
+
public static String queryToString(Configuration conf, String query) throws
Exception {
return queryToString(conf, query, true);
}
- public static String queryToString(Configuration conf, String query, boolean
includeHeader)
+
+ public static String queryToString(Configuration conf, String query, boolean
includeHeader) throws Exception {
+ return queryToString(conf, query, includeHeader, " ");
+ }
+
+ public static String queryToCsv(Configuration conf, String query) throws
Exception {
Review Comment:
okay,got is, it's for debugging purposes, it's fine to have it this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
