jfsii commented on code in PR #5092:
URL: https://github.com/apache/hive/pull/5092#discussion_r1500040094
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreClientWithLocalCache.java:
##########
@@ -61,7 +61,6 @@
import org.apache.hadoop.hive.metastore.api.TableValidWriteIds;
import org.apache.hadoop.hive.metastore.api.UniqueConstraintsRequest;
import org.apache.hadoop.hive.metastore.api.UniqueConstraintsResponse;
-import org.apache.hadoop.hive.metastore.conf.MetastoreConf;
Review Comment:
Is this diff required?
##########
data/conf/perf/tpcds30tb/tez/hive-site.xml:
##########
@@ -17,6 +17,10 @@
limitations under the License.
-->
<configuration>
+ <property>
Review Comment:
Is this required for this commit?
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java:
##########
@@ -282,4 +282,11 @@ public boolean skipAuthorization() {
}
return super.skipAuthorization();
}
+
Review Comment:
Does anything in the EXPLAIN output show if it is using cached metadata or
not? If so, could we write a Q file test that ensures this continues to work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
