SourabhBadhya commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1505590111
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java:
##########
@@ -512,7 +555,30 @@ private void setupWorkWhenUsingManifestFile(MapWork
mapWork, List<FileStatus> fi
mapWork.setUseInputPathsDirectly(true);
}
- private Map<FileStatus, List<FileStatus>> getManifestDirs(FileSystem inpFs,
List<FileStatus> fileStatuses)
+ private void setupWorkWhenUsingCustomHandler(MapWork mapWork, Path dirPath,
+ StorageHandlerMergeProperties
mergeProperties) throws ClassNotFoundException {
+ Map<String, Operator<? extends OperatorDesc>> aliasToWork =
mapWork.getAliasToWork();
+ Map<Path, PartitionDesc> pathToPartitionInfo =
mapWork.getPathToPartitionInfo();
+ Operator<? extends OperatorDesc> op = aliasToWork.get(dirPath.toString());
+ PartitionDesc partitionDesc = pathToPartitionInfo.get(dirPath);
+ Path tmpDir = mergeProperties.getTmpLocation();
Review Comment:
`mergeProperties` is present when its used under storage handler which
supports it. The boolean `customStorageHandler` if true should make sure that
`mergeProperties`is not null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
