abstractdog commented on code in PR #5103:
URL: https://github.com/apache/hive/pull/5103#discussion_r1505906262
##########
ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecuteLostAMQueryPlugin.java:
##########
@@ -44,15 +50,28 @@ public void run(HookContext hookContext) throws Exception {
if (hookContext.getHookType() == HookContext.HookType.ON_FAILURE_HOOK) {
Throwable exception = hookContext.getException();
- if (exception != null && exception.getMessage() != null) {
+ if (!(exception instanceof TezRuntimeException)) {
+ LOG.info("Exception is not a TezRuntimeException, no need to check
further with ReExecuteLostAMQueryPlugin");
+ return;
+ }
+
+ TezRuntimeException tre = (TezRuntimeException)exception;
+
+ if (tre != null && tre.getMessage() != null) {
Review Comment:
ack
##########
ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecuteLostAMQueryPlugin.java:
##########
@@ -33,6 +36,9 @@
public class ReExecuteLostAMQueryPlugin implements IReExecutionPlugin {
private static final Logger LOG =
LoggerFactory.getLogger(ReExecuteLostAMQueryPlugin.class);
private boolean retryPossible;
+ // a list to track DAG ids seen by this re-execution plugin during the same
query
+ // it can help a lot with identifying the previous DAGs in case of retries
+ private List<String> dagIds = new ArrayList<>();
Review Comment:
ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
