deniskuzZ commented on code in PR #5111: URL: https://github.com/apache/hive/pull/5111#discussion_r1511031471
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ########## @@ -661,6 +669,7 @@ private static FilesForCommit collectResults(int numTasks, ExecutorService execu Collection<DataFile> dataFiles = new ConcurrentLinkedQueue<>(); Collection<DeleteFile> deleteFiles = new ConcurrentLinkedQueue<>(); Collection<DataFile> referencedDataFiles = new ConcurrentLinkedQueue<>(); + Collection<CharSequenceSet> referencedDataFilesInDeleteFiles = new ConcurrentLinkedQueue<>(); Review Comment: why is that Collection<CharSequenceSet> and not simply CharSequenceSet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org