deniskuzZ commented on code in PR #5111:
URL: https://github.com/apache/hive/pull/5111#discussion_r1511052102
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/HiveIcebergDeleteWriter.java:
##########
@@ -68,6 +69,7 @@ public void write(Writable row) throws IOException {
@Override
public FilesForCommit files() {
List<DeleteFile> deleteFiles = ((DeleteWriteResult)
writer.result()).deleteFiles();
- return FilesForCommit.onlyDelete(deleteFiles);
+ CharSequenceSet referencedDataFilesInDeleteFiles = ((DeleteWriteResult)
writer.result()).referencedDataFiles();
Review Comment:
````
Set<CharSequence> referencedDataFiles = ((DeleteWriteResult)
writer.result()).referencedDataFiles();
````
please also change the type for replacedDataFiles to Set
````
Set<DataFile> replacedDataFiles;
this.replacedDataFiles = Sets.newHashSet();
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
