abstractdog commented on PR #2866: URL: https://github.com/apache/hive/pull/2866#issuecomment-1986802071
@jsoref : sorry, I completely forgot about this one, took a look again I can see that the issue you faced comes while running tests, whereas the enforcer applies to the compilation phase too, right? I believe we already took care of Hive Java11 compile-time compatibility, and even if some of the unit tests fail, we've been running downstream/internal versions of hive on Java11, so from this point of view, I would not go towards complete Java8 enforcement, but still, early message makes sense to me, let's consider below points: 1. we did mockito upgrade and powermock removal recently, which definitely looks related to the Java11 error that you pasted, can you double-check if it's still the case (maybe we solved the problem in the meantime :) ) 2. assuming that we still have some issues on JDK11 testing, I'm fine with this patch, here is why: I was a bit against this, because I felt enforcing Java8 is kind of preserving the current state, however, it's not :) our code and lack of effort that really preserves this state, and anytime we're ready to move to complete JDK11 compile + unit test compatibility, we can easily remove this rule would you be so kind to double-check what I asked above in 1), and we can proceed with this PR + followup tickets -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
