SourabhBadhya commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1525845819
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java:
##########
@@ -208,14 +235,17 @@ public List<Task<?>> getTasks(HiveConf conf, Object
objCtx) {
} else {
// static partition and list bucketing
generateActualTasks(conf, resTsks, trgtSize, avgConditionSize,
mvTask, mrTask,
- mrAndMvTask, dirPath, inpFs, ctx, work, lbLevel,
manifestFilePresent);
+ mrAndMvTask, dirPath, inpFs, ctx, work, lbLevel,
manifestFilePresent, storageHandler);
}
}
+ } else if (useCustomStorageHandler) {
+ generateActualTasks(conf, resTsks, trgtSize, avgConditionSize, mvTask,
mrTask,
+ mrAndMvTask, dirPath, inpFs, ctx, work, 0, false,
storageHandler);
} else {
Utilities.FILE_OP_LOGGER.info("Resolver returning movetask for " +
dirPath);
resTsks.add(mvTask);
}
- } catch (IOException e) {
+ } catch (ClassNotFoundException | HiveException | IOException e) {
Review Comment:
Added another `catch` clause with these 2 exceptions.
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java:
##########
@@ -512,7 +553,30 @@ private void setupWorkWhenUsingManifestFile(MapWork
mapWork, List<FileStatus> fi
mapWork.setUseInputPathsDirectly(true);
}
- private Map<FileStatus, List<FileStatus>> getManifestDirs(FileSystem inpFs,
List<FileStatus> fileStatuses)
+ private void setupWorkWhenUsingCustomHandler(MapWork mapWork, Path dirPath,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
