zhangbutao commented on code in PR #5138:
URL: https://github.com/apache/hive/pull/5138#discussion_r1532024162
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g:
##########
@@ -503,6 +503,8 @@ alterStatementSuffixExecute
-> ^(TOK_ALTERTABLE_EXECUTE KW_EXPIRE_SNAPSHOTS KW_RETAIN $numToRetain)
| KW_EXECUTE KW_DELETE KW_ORPHAN_FILES (KW_OLDER KW_THAN LPAREN
(timestamp=StringLiteral) RPAREN)?
-> ^(TOK_ALTERTABLE_EXECUTE KW_ORPHAN_FILES $timestamp?)
+ | KW_EXECUTE KW_RENAME KW_BRANCH sourceBranch=StringLiteral KW_TO
targetBranch=StringLiteral
Review Comment:
Agreed with @deniskuzZ .
I think we need to reach an agreement on when to use this `execute` syntax.
IMHO, `execute` is good for some optimization & maintenance operation. I
think TrinoDB also thought
so:(https://trino.io/docs/current/connector/iceberg.html#alter-table-execute)
For basic operation, rename can use the same simple syntax like create/drop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
