ramesh0201 commented on code in PR #5155:
URL: https://github.com/apache/hive/pull/5155#discussion_r1538087842
##########
ql/src/test/results/clientpositive/llap/prepare_plan.q.out:
##########
@@ -128,11 +128,11 @@ STAGE PLANS:
Processor Tree:
ListSink
-PREHOOK: query: prepare pcount from select count(*) from src where key > ?
Review Comment:
Prepare queries doesn't go through the execution phase as per current
implementation
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L166C30-L166C44
So the pre-execution and post-execution hooks are skipped as well, which is
why we miss seeing those results in the q.out file. I feel it is ok. Just that
we need to use compilation side hooks to test the prepare queries.
explain..prepare still shows up in the q.out files.
So I am not sure if we have to create a follow up to test the prepare
queries? what is your take?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
