zabetak commented on code in PR #5163:
URL: https://github.com/apache/hive/pull/5163#discussion_r1538731131
##########
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:
##########
@@ -453,8 +452,7 @@ public RecordReader getRecordReader(InputSplit split,
JobConf job,
LOG.info("Ignoring exception while getting record reader as limit is
reached", rootCause);
innerReader = new NullRowsRecordReader(job, split);
} else {
- innerReader = HiveIOExceptionHandlerUtil
- .handleRecordReaderCreationException(e, job);
+ throw e;
Review Comment:
If we throw the same exception that we caught the stacktrace will not show
that we are inside the catch block (although we could possibly infer it from
the code). Maybe it would be more straightforward to do `new
RuntimeException("some msg", e)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
