shivjha30 commented on code in PR #5000:
URL: https://github.com/apache/hive/pull/5000#discussion_r1547102223
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java:
##########
@@ -344,7 +358,7 @@ private void analyzeLoad(ASTNode ast) throws
SemanticException {
}
// make sure the arguments make sense
- List<FileStatus> files = applyConstraintsAndGetFiles(fromURI,
ts.tableHandle);
+ List<FileStatus> files = applyConstraintsAndGetFiles(fromURI,
ts.tableHandle, srcs);
Review Comment:
The changes were introduced only for Partition tables, there is no change in
behaviour for Non Partition.
For partition tables for local , Before the fix the exception thrown was
File Not Found from Node Manager, if file would be present at hs2. For hdfs +
partition, no exception is getting thrown. After the fix the exception will be
thrown from Hive Server itself, and the exception now would be Semantic
Exception for both hdfs and local .
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java:
##########
@@ -344,7 +358,7 @@ private void analyzeLoad(ASTNode ast) throws
SemanticException {
}
// make sure the arguments make sense
- List<FileStatus> files = applyConstraintsAndGetFiles(fromURI,
ts.tableHandle);
+ List<FileStatus> files = applyConstraintsAndGetFiles(fromURI,
ts.tableHandle, srcs);
Review Comment:
<img width="394" alt="image"
src="https://github.com/apache/hive/assets/149884343/658eb103-9c1a-4fd3-92f6-19228474660c";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
