deniskuzZ commented on code in PR #5173:
URL: https://github.com/apache/hive/pull/5173#discussion_r1549727435
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -2104,9 +2106,14 @@ public void truncateTable(String catName, String dbName,
String tableName, List<
private void truncateTableInternal(String catName, String dbName, String
tableName,
List<String> partNames, String validWriteIds, long writeId, boolean
deleteData)
throws TException {
+ EnvironmentContext context = new EnvironmentContext();
+ if (tableName.contains(".")) {
Review Comment:
wait, are we doing this because we concatenate in API? can we extend API
with `String tableMetaRef`
````
getMSC().truncateTable(table.getDb(), table.getTable(), table.getMetaRef,
partNames);
````
meybe we can even do `getMSC().truncateTable((TableName table, List<String>
partNames)
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -2104,9 +2106,14 @@ public void truncateTable(String catName, String dbName,
String tableName, List<
private void truncateTableInternal(String catName, String dbName, String
tableName,
List<String> partNames, String validWriteIds, long writeId, boolean
deleteData)
throws TException {
+ EnvironmentContext context = new EnvironmentContext();
+ if (tableName.contains(".")) {
Review Comment:
wait, are we doing this because we concatenate in API? can we extend API
with `String tableMetaRef`
````
getMSC().truncateTable(table.getDb(), table.getTable(), table.getMetaRef,
partNames);
````
meybe we can even do `getMSC().truncateTable((TableName table, List<String>
partNames)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
