deniskuzZ commented on code in PR #5174:
URL: https://github.com/apache/hive/pull/5174#discussion_r1551527963
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java:
##########
@@ -444,4 +572,12 @@ private AvailableSlotsCalculator
getAvailableSlotsCalculator() throws Exception
slotsCalculator.initialize(conf, this);
return slotsCalculator;
}
+
+ /**
+ * Convenience method for callers that want to disable the serialization of
splits to filesystem.
+ */
+ public HiveSplitGenerator splitFsSerialization(boolean splitFsSerialization)
{
Review Comment:
wait, input param is not used at all
also, why do you need this method at all, since you pass the jobConf to
HiveSplitGenerator constructor? pass conf with disabled serialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
