deniskuzZ commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1558987660
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/HeartbeatTxnRangeFunction.java:
##########
@@ -82,7 +82,7 @@ public HeartbeatTxnRangeResponse
execute(MultiDataSourceJdbcResource jdbcResourc
}
if (updateCnt == numTxnsToHeartbeat) {
//fast pass worked, i.e. all txns we were asked to heartbeat were Open
as expected
- context.rollbackToSavepoint(savePoint);
+ context.createSavepoint();
Review Comment:
savepoint is kinda commit, same thing is done after refactor in
heartbeatTxn/Locks, but we shouldn't rollback for sure - heartbeat won't be
applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
