zratkai commented on code in PR #5188: URL: https://github.com/apache/hive/pull/5188#discussion_r1559244336
########## ql/src/java/org/apache/hadoop/hive/ql/io/IOContext.java: ########## @@ -51,7 +51,7 @@ public class IOContext { */ private RecordIdentifier ri; private boolean isDeletedRecord; - private PositionDeleteInfo pdi; + private ThreadLocal<PositionDeleteInfo> pdi = new ThreadLocal<>(); Review Comment: Should not be the whole IOContext class immutable? It contains many fields which can be modified asynchronously and it can cause concurrency issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org