wecharyu commented on code in PR #5198:
URL: https://github.com/apache/hive/pull/5198#discussion_r1567738443
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1052,7 +1052,7 @@ public enum ConfVars {
"get_partitions_by_names, \n" +
"get_partitions_with_auth, \n" +
"get_partitions_by_filter, \n" +
- "get_partitions_spec_by_filter, \n" +
Review Comment:
Minor typo fix.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -3466,11 +3467,49 @@ protected List<String> getJdoResult(
}.run(true);
}
- private List<String> getPartitionNamesViaOrm(Table table, ExpressionTree
tree, String order,
Review Comment:
Refactor this method because it's used in partition level, and do not needs
the cd field of table, but the original parameter `Table table` retrieved via
ORM must include cd information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
