deniskuzZ commented on code in PR #5123:
URL: https://github.com/apache/hive/pull/5123#discussion_r1569041910


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -1187,6 +1187,11 @@ private List<Partition> getPartitionsByQuery(String 
catName, String dbName, Stri
       MetastoreDirectSqlUtils.timingTrace(doTrace, queryText, start, 
queryTime);
     }
     String partIds = getIdListForIn(partitions.keySet());
+
+    if (partIds.isEmpty()) {

Review Comment:
   do we still need this after you've added iceberg partition list 
functionality in PartitionUtils?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to