deniskuzZ commented on code in PR #5123:
URL: https://github.com/apache/hive/pull/5123#discussion_r1577440548
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -777,6 +783,16 @@ default List<Partition>
getPartitionsByExpr(org.apache.hadoop.hive.ql.metadata.T
"for a table.");
}
+ default List<Partition>
getPartitions(org.apache.hadoop.hive.ql.metadata.Table table,
+ Map<String, String> partitionSpec) throws SemanticException {
+ throw new UnsupportedOperationException("Storage handler does not support
getting partitions for a table.");
+ }
+
+ default Partition getPartition(org.apache.hadoop.hive.ql.metadata.Table
table, Map<String, String> partSpec)
Review Comment:
`partitionSpec`
please keep param names consistent, that is an interface. also would be nice
to add javadocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
