wecharyu commented on code in PR #5206:
URL: https://github.com/apache/hive/pull/5206#discussion_r1578205825
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java:
##########
@@ -409,10 +409,13 @@ public void testListPartitionsByValues() throws Exception
{
assertEquals(0, partitions.size());
}
- @Test(expected = MetaException.class)
Review Comment:
Empty part_vals should not throw `MetaException` because we support it in
`ObjectStore` and regard it as fetching all partitions:
https://github.com/apache/hive/blob/2d855b27d31db6476f18870651db6987816bb5e3/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L3890-L3893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
