zhangbutao commented on code in PR #5220: URL: https://github.com/apache/hive/pull/5220#discussion_r1581992469
########## parser/src/java/org/apache/hadoop/hive/ql/parse/ReplClauseParser.g: ########## @@ -0,0 +1,110 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ +parser grammar ReplClauseParser; Review Comment: Will we consider using Antlr4 in the future? IMO, most of OSS use Antlr4, and only Hive uses Antlr3, and Antlr has not been updated for many years & Antlr4 is more easy to use than Antlr3. It would be great if we could incrementally update `HiveParser.g` it to a higher version `HiveParser.g4`. :) A related uncompleted PR is https://github.com/apache/hive/pull/4058. This comment may go beyond the scope of the PR. We can make this change happen in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
