okumin commented on code in PR #5077: URL: https://github.com/apache/hive/pull/5077#discussion_r1583240220
########## ql/src/test/queries/clientpositive/cbo_cte_materialization.q: ########## @@ -0,0 +1,28 @@ +--! qt:dataset:src + +set hive.optimize.cte.materialize.threshold=1; +set hive.optimize.cte.materialize.full.aggregate.only=false; Review Comment: I'm checking the whole execution and what the flag does. Disabling `hive.query.planmapper.link.relnodes`, no aux signature is created, and no merge across Operators doesn't happen. I feel it is not consistent with the description, `Whether to link Calcite nodes to runtime statistics`. I guess the direct problem will be resolved if we skip linking RelNodes with Operators when `hive.query.planmapper.link.relnodes=false` is configured. That sounds more consistent with the description. I'm putting my additional notes here. I tried to put some to-be solutions but it could not be very easy. https://docs.google.com/document/d/1LCST23cSBZglBzjhnCqHlpcLv6xrXRBxU_wszSDAk9w/edit?usp=sharing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
