dengzhhu653 commented on code in PR #5198:
URL: https://github.com/apache/hive/pull/5198#discussion_r1588609569
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -4156,16 +4210,10 @@ private String getDefaultPartitionName(String
inputDefaultPartName) {
*/
private boolean getPartitionNamesPrunedByExprNoTxn(String catName, String
dbName, String tblName, List<FieldSchema> partColumns, byte[] expr,
String defaultPartName,
short maxParts, List<String> result) throws MetaException {
- result.addAll(getPartitionNamesNoTxn(
- catName,
- dbName,
- tblName,
- maxParts));
- return expressionProxy.filterPartitionsByExpr(
- partColumns,
- expr,
- getDefaultPartitionName(defaultPartName),
- result);
+ result.addAll(getPartitionNamesNoTxn(catName, dbName, tblName, (short)
-1));
Review Comment:
nit: do we need to consider the `maxParts` instead of `-1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
