zhangbutao commented on code in PR #5222:
URL: https://github.com/apache/hive/pull/5222#discussion_r1590001048
##########
iceberg/patched-iceberg-core/src/main/java/org/apache/iceberg/hadoop/HadoopInputFile.java:
##########
@@ -214,6 +214,10 @@ public FileStatus getStat() {
return lazyStat();
}
+ public void setStat(FileStatus stat) {
Review Comment:
Do we need this method?
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java:
##########
@@ -142,9 +142,10 @@ public enum HiveOperationType {
ALTERTABLE_CREATEBRANCH,
ALTERTABLE_DROPBRANCH,
ALTERTABLE_RENAMEBRANCH,
- ALTERTABLE_REPLACEBRANCH,
+ ALTERTABLE_REPLACESNAPSHOTREF,
ALTERTABLE_CREATETAG,
ALTERTABLE_DROPTAG,
+ ALTERTABLE_REPLACETAG,
Review Comment:
Do we still need this?
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:
##########
@@ -83,6 +83,7 @@
import org.apache.commons.lang3.StringEscapeUtils;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.filecache.DistributedCache;
+import org.apache.hadoop.fs.CommonPathCapabilities;
Review Comment:
No need this import...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
