mdayakar commented on code in PR #5231:
URL: https://github.com/apache/hive/pull/5231#discussion_r1590560856
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1028,9 +1028,13 @@ void cleanup() {
* Output information about unhandled exceptions
*/
public void printExceptions() {
+ List<Signal> userDefinedSignals = new ArrayList<>();
Review Comment:
> Is it allowed to add the same Signal more than one times?
As per code, same signal is not getting added more than once.
> Does the order of Signals matter?
Here to store the signals Stack data structure is getting used so might be
the order matters thats why pushing the userdefined signals in the same order
which they were present in Stack before processing other signals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
