zabetak commented on code in PR #5022:
URL: https://github.com/apache/hive/pull/5022#discussion_r1596661067
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java:
##########
@@ -244,6 +245,7 @@ public void analyzeInternal(ASTNode ast) throws
SemanticException {
} else {
analyzeLoad(ast);
}
+ queryState.setCommandType(HiveOperation.LOAD);
Review Comment:
The `HiveOperation` primarily purpose is to ensure that authorization and
transaction information is passed and used correctly during the compilation and
execution of Hive queries. `HiveOperation` is not meant for end-user
consumption so display purposes are a secondary concern.
A `LOAD` operation and a `QUERY` operation have different implications in
terms of authorization and transactions.
* Is it OK to change the query state at the end of the analysis phase?
* Will compilation and execution run under the same
authorization/transaction semantics?
* Do we have any kind of authorization/transaction tests that ensure that
things work correctly for `LOAD` statements after this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
