okumin commented on code in PR #5245:
URL: https://github.com/apache/hive/pull/5245#discussion_r1597771528
##########
ql/src/test/results/clientpositive/llap/count.q.out:
##########
@@ -811,7 +811,7 @@ STAGE PLANS:
Execution mode: llap
Reduce Operator Tree:
Group By Operator
- aggregations: count(DISTINCT KEY._col1:0._col0),
count(DISTINCT KEY._col1:1._col0), sum(VALUE._col0), sum(VALUE._col1),
sum(VALUE._col2), sum(KEY._col1:0._col0), sum(KEY._col1:1._col0),
sum(KEY._col0), sum(DISTINCT KEY._col1:2._col0), sum(DISTINCT KEY._col1:3._col0)
+ aggregations: count(DISTINCT KEY._col1:0._col0),
count(DISTINCT KEY._col1:1._col0), sum(VALUE._col0), sum(VALUE._col1),
sum(VALUE._col2), sum(KEY._col1:0._col0), sum(KEY._col1:1._col0),
sum(KEY._col1:2._col0), sum(DISTINCT KEY._col1:2._col0), sum(DISTINCT
KEY._col1:3._col0)
Review Comment:
In this case, the first `KEY._col0` doesn't conflict generated columns for
DISTINCT UDAFs. So, technically, the problem would not happen without the
change of this PR, which mean either seems to be acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
