dengzhhu653 commented on code in PR #5206:
URL: https://github.com/apache/hive/pull/5206#discussion_r1598478460
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java:
##########
@@ -609,4 +609,16 @@ public static void throwMetaOrRuntimeException(Exception
e) throws MetaException
throw new RuntimeException(e);
}
}
+
+ static int getCountOfQuery(PersistenceManager pm, String queryText, Object[]
params) {
Review Comment:
nit: how about declaring this method as `getCountOfQuery(Query query,
Object[] params)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
