dengzhhu653 commented on PR #5223:
URL: https://github.com/apache/hive/pull/5223#issuecomment-2107608744
> Does `drop partitions by names` have any advantages over `drop partitions
by expressions`?
>
> My concern is that we already have lots of redundant api and other
components(Spark/Trino/Impala) may not need the new added api.
>
> But if the new added api has some advantages over old api, i think we can
move on.
>
> I also want to listen to other folks's opinions. :)
+1
This change looks like a variant of `dropPartitions` based on one current
implementation, it's not a good choice to declare it as a first class API.
If we really need to add it in the future, I would prefer making it an util
method instead in `MetaStoreUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
