deniskuzZ commented on code in PR #5241:
URL: https://github.com/apache/hive/pull/5241#discussion_r1600042371
##########
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampsHive2Compatibility.java:
##########
@@ -97,6 +97,21 @@ void
testWriteHive2ReadHive4UsingLegacyConversionWithZone(String timestampString
}
}
+ @ParameterizedTest(name = "{0}")
+ @MethodSource("generateJulianLeapYearTimestamps")
+ void testWriteHive2ReadHive4UsingLegacyConversionWithJulianLeapYears(String
timestampString) {
+ TimeZone original = TimeZone.getDefault();
+ try {
+ String zoneId = "Asia/Singapore";
Review Comment:
please check edge cases: [UTC+14](https://en.wikipedia.org/wiki/UTC+14:00)
write UTC-12 read, and reversed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
