kuczoram commented on code in PR #5192:
URL: https://github.com/apache/hive/pull/5192#discussion_r1602791269
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java:
##########
@@ -54,6 +54,8 @@ public abstract class QueryCompactor implements Compactor {
private static final Logger LOG =
LoggerFactory.getLogger(QueryCompactor.class.getName());
private static final String COMPACTOR_PREFIX = "compactor.";
+ protected CompactionQueryBuilderFactory compactionQueryBuilderFactory = new
CompactionQueryBuilderFactory();
Review Comment:
Oh, sorry, forgot to send the answer here. I created an instance of the
CompactionQueryBuilderFactory here, but it is used in the subclasses, that's
why it is protected. But I realized, it is not a very good approach, so I
changed it to create the instance where it is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
