wecharyu commented on code in PR #5206:
URL: https://github.com/apache/hive/pull/5206#discussion_r1608576789
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java:
##########
@@ -1201,7 +1201,7 @@ public List<String> listPartitionNames(String catName,
String dbName, String tbl
public List<String> listPartitionNames(String catName, String dbName, String
tblName,
List<String> partVals, int maxParts) throws TException {
org.apache.hadoop.hive.metastore.api.Table table = getTempTable(dbName,
tblName);
- if (table == null) {
+ if (table == null || partVals == null) {
Review Comment:
> the PartitionTree is for the temporary table to process the partition
request, it works at the client side, why not put the check here?
Because `get_partitions_ps_with_auth` support null and empty part_vals, the
null check is added in client side. So in `PartitionTree` we can also follow
the server behavior and push null check in `SessionHiveMetaStoreClient`. This
change seems to have no side effects, and in turn supports empty part_vals like
`HiveMetaStoreClient`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
