deniskuzZ commented on code in PR #5215:
URL: https://github.com/apache/hive/pull/5215#discussion_r1615845852
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -442,10 +446,11 @@ public Map<String, String> getBasicStatistics(Partish
partish) {
org.apache.hadoop.hive.ql.metadata.Table hmsTable = partish.getTable();
// For write queries where rows got modified, don't fetch from cache as
values could have changed.
Table table = getTable(hmsTable);
+ Snapshot snapshot = getSpecificSnapshot(partish.getTable(), table);
Review Comment:
should we move snapshot fetch under the `if`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]