mayankkunwar commented on code in PR #5265: URL: https://github.com/apache/hive/pull/5265#discussion_r1618596851
########## ql/src/test/results/clientpositive/llap/file_with_delimiter.q.out: ########## @@ -0,0 +1,63 @@ +PREHOOK: query: create external table test(code string,name string) +ROW FORMAT SERDE + 'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe' + WITH SERDEPROPERTIES ( + 'field.delim'='\t') + STORED AS INPUTFORMAT + 'org.apache.hadoop.mapred.TextInputFormat' + OUTPUTFORMAT + 'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat' +#### A masked pattern was here #### + TBLPROPERTIES ( + 'skip.header.line.count'='1', + 'textinputformat.record.delimiter'='|') +PREHOOK: type: CREATETABLE +#### A masked pattern was here #### +PREHOOK: Output: database:default +PREHOOK: Output: default@test +POSTHOOK: query: create external table test(code string,name string) +ROW FORMAT SERDE + 'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe' + WITH SERDEPROPERTIES ( + 'field.delim'='\t') + STORED AS INPUTFORMAT + 'org.apache.hadoop.mapred.TextInputFormat' + OUTPUTFORMAT + 'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat' +#### A masked pattern was here #### + TBLPROPERTIES ( + 'skip.header.line.count'='1', + 'textinputformat.record.delimiter'='|') +POSTHOOK: type: CREATETABLE +#### A masked pattern was here #### +POSTHOOK: Output: database:default +POSTHOOK: Output: default@test +PREHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/header_footer_table_4/0003.txt' INTO TABLE test +PREHOOK: type: LOAD +#### A masked pattern was here #### +PREHOOK: Output: default@test +POSTHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/header_footer_table_4/0003.txt' INTO TABLE test +POSTHOOK: type: LOAD +#### A masked pattern was here #### +POSTHOOK: Output: default@test +PREHOOK: query: Select count(*) from test +PREHOOK: type: QUERY +PREHOOK: Input: default@test +#### A masked pattern was here #### +POSTHOOK: query: Select count(*) from test +POSTHOOK: type: QUERY +POSTHOOK: Input: default@test +#### A masked pattern was here #### +3 +PREHOOK: query: Select * from test +PREHOOK: type: QUERY +PREHOOK: Input: default@test +#### A masked pattern was here #### +POSTHOOK: query: Select * from test +POSTHOOK: type: QUERY +POSTHOOK: Input: default@test +#### A masked pattern was here #### +A AAAA NULL Review Comment: The "select count(*)" query was giving wrong output for the added qtest as "1". After this PR, the output is 3, as expected. I have used same example from the Jira ticket, which was not working. But the "Select *" query is working as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
