zabetak commented on code in PR #5172:
URL: https://github.com/apache/hive/pull/5172#discussion_r1618679014
##########
beeline/pom.xml:
##########
@@ -276,6 +276,11 @@
<artifactId>maven-shade-plugin.log4j2-cachefile-transformer</artifactId>
<version>2.1</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-core</artifactId>
+ <version>${log4j2.version}</version>
+ </dependency>
Review Comment:
Why do we need to add this? Did we use log4j transitively?
##########
standalone-metastore/metastore-tools/metastore-benchmarks/pom.xml:
##########
@@ -88,6 +88,12 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
The slf4j-log4j12 is an explicit binding of slf4j with log4j 1.2 thus this
exclusion here doesn't make sense. The whole dependency must be dropped.
Just below we have log4j-slf4j-impl which is an SLF4J binding with Log4j 2
so I think that's all we need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
