deniskuzZ commented on code in PR #5251:
URL: https://github.com/apache/hive/pull/5251#discussion_r1624750759
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -328,4 +334,40 @@ public static PartitionData toPartitionData(StructLike
key, Types.StructType key
}
return data;
}
+
+ /**
+ * Generates {@link JobContext}s for the OutputCommitter for the specific
table.
+ * @param configuration The configuration used for as a base of the JobConf
+ * @param tableName The name of the table we are planning to commit
+ * @param branchName the name of the branch
+ * @return The generated Optional JobContext list or empty if not presents.
+ */
+ static List<JobContext> generateJobContext(Configuration configuration,
String tableName,
Review Comment:
i don't think it's a proper place for this, it should be part of
`OutputCommitter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
