zhangbutao commented on code in PR #5282:
URL: https://github.com/apache/hive/pull/5282#discussion_r1631894680
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -175,14 +174,19 @@ CombinedScanTask> applyConfig(
Long openFileCost = splitSize > 0 ? splitSize :
TableProperties.SPLIT_SIZE_DEFAULT;
scan = scan.option(TableProperties.SPLIT_OPEN_FILE_COST,
String.valueOf(openFileCost));
}
- String schemaStr = conf.get(InputFormatConfig.READ_SCHEMA);
- if (schemaStr != null) {
- scan.project(SchemaParser.fromJson(schemaStr));
- }
-
- String[] selectedColumns =
conf.getStrings(InputFormatConfig.SELECTED_COLUMNS);
- if (selectedColumns != null) {
- scan.select(selectedColumns);
+ // TODO: Currently, this projection optimization stored on scan is not
being used effectively on Hive side, as
Review Comment:
@deniskuzZ Added TODO here, Please help to check if it is ok.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
