Re: [PR] HIVE-28272: Support setting per-session S3 credentials in Warehouse [hive]

[via GitHub]

zhangbutao commented on PR #5257:
URL: https://github.com/apache/hive/pull/5257#issuecomment-2162013717

   > @zhangbutao , i think the configs needs to be added to whitelist
   > 
   > 
https://github.com/apache/hive/blob/33cadc5b498b57f779cddc9bf4e3f8aef2d9f6dc/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L6741
   > 
   > otherwise we cannot modify it at runtime.
   > <img alt="Runtime_conf" width="1466" 
src="https://private-user-images.githubusercontent.com/49618756/338661905-b7a09b72-cb06-4f96-bade-1b0443e94e06.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgxNjE1MDAsIm5iZiI6MTcxODE2MTIwMCwicGF0aCI6Ii80OTYxODc1Ni8zMzg2NjE5MDUtYjdhMDliNzItY2IwNi00Zjk2LWJhZGUtMWIwNDQzZTk0ZTA2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjEyVDAzMDAwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIyMWU4OWE0ZjcxMmQ3ZTc3MTU5ZDZjOTA3MjU2YzYzODMwMmNmM2ZmMWEwZjYxMDk5NWY3OGFlNTg1ZGFjMGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sNrxJWwisyGf3k5DMafAShjQIGpM_kqjGokJtbAD3KM";>
   
   Yes, you are right. need to add these conf to whitelist.
   Will optimize this if any other folks have the futher comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org