ayushtkn commented on code in PR #5293:
URL: https://github.com/apache/hive/pull/5293#discussion_r1637881365
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -5860,6 +5860,16 @@ private HiveStorageHandler
createStorageHandler(org.apache.hadoop.hive.metastore
}
}
+ private static String
getStorageHandlerClassName(org.apache.hadoop.hive.metastore.api.Table tbl) {
+ String tableType = tbl.getParameters().get(HiveMetaHook.TABLE_TYPE);
+ String metaTableStorage = tbl.getParameters().get(META_TABLE_STORAGE);
+ if (HiveMetaHook.ICEBERG.equalsIgnoreCase(tableType) && metaTableStorage
== null) {
+ return "org.apache.iceberg.mr.hive.HiveIcebergStorageHandler";
Review Comment:
changed to use constant, as discussed
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -1071,6 +1071,16 @@ public void
postGetTable(org.apache.hadoop.hive.metastore.api.Table hmsTable) {
if (!"1".equals(formatVersion)) {
hmsTable.getParameters().put(TableProperties.FORMAT_VERSION,
formatVersion);
}
+ // Set the serde info
+
hmsTable.getSd().setInputFormat("org.apache.iceberg.mr.hive.HiveIcebergInputFormat");
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
