kasakrisz commented on code in PR #5196:
URL: https://github.com/apache/hive/pull/5196#discussion_r1665425495
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java:
##########
@@ -179,7 +178,7 @@ protected HivePointLookupOptimizerRule(
this.minNumORClauses = minNumORClauses;
}
- public RexNode analyzeRexNode(RexBuilder rexBuilder, RexNode condition) {
+ public static RexNode analyzeRexNode(RexBuilder rexBuilder, RexNode
condition, int minNumORClauses) {
Review Comment:
Thanks for the explanation. I think the method name `analyzeRexNode` doesn't
express what it actually does and calling it from other classes than
`HivePointLookupOptimizerRule` makes more confusion. By making it static it
became a utility method; many of those are moved to utility classes. I don't
have a strong opinion about it, I leave it to you.
Could you please rename it to something more descriptive? How about
`transformOrToInAndInequalityToBetween` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
